X-Git-Url: https://defaria.com/gitweb/?a=blobdiff_plain;f=lib%2FSpeak.pm;h=c98feca6ee50a43d4e9ddd1760ab015b4b846fd6;hb=10b78beac53843192f7da8a6dbaa2d5e0572b307;hp=d46249075db8f77950fdf171ba1410040b809adc;hpb=a9a87bbe82dc57fbb837f86139419eaf76095105;p=clearscm.git diff --git a/lib/Speak.pm b/lib/Speak.pm index d462490..c98feca 100644 --- a/lib/Speak.pm +++ b/lib/Speak.pm @@ -83,7 +83,7 @@ Otherwise the text in the clipboard will be used. =item $log -If provided, errors and messages will be logged to the logfile, otherwise stdout +If provided, errors and messages will be logged to the logfile, otherwise to speak.log =back @@ -103,13 +103,16 @@ Returns: =cut - if (-f "$FindBin::Bin/shh") { - $msg .= ' [silent]'; - if ($log) { - $log->msg($msg); - } else { - verbose $msg; - } # if + $log = Logger->new( + path => '/var/local/log', + name => 'speak', + timestamped => 'yes', + append => 1, + ) unless $log; + + if (-f "$FindBin::Bin/../data/shh") { + $msg .= ' [silent shh]'; + $log->msg($msg); return; } # if @@ -120,38 +123,15 @@ Returns: # Handle the case where $msg is a filehandle $msg = <$msg> if ref $msg eq 'GLOB'; - # We can't have two speakers going at the same time so if we have an error - # backoff a little and try again. - my $attempts = 0; - my $maxretries = 3; - my $backoff = 2; - - my ($status, @output); - - while ($attempts++ < $maxretries) { - ($status, @output) = Execute "/usr/local/bin/gt \"$msg\""; - - if ($status) { - my $errmsg = "Unable to speak (Status: $status) - " . join "\n", @output; - - if ($log) { - $log->err($errmsg); - } else { - error $errmsg; - } # if + # Log message to log file if $log was passed in. + $log->msg($msg); - sleep $backoff++; - } else { - return; # We said our piece... - } # if - } # while + my ($status, @output) = Execute "/usr/local/bin/gt \"$msg\""; - my $errmsg = 'Maximum retries exceeded - terminating'; + if ($status) { + my $errmsg = "Unable to speak (Status: $status) - " . join "\n", @output; - if ($log) { - $log->err($errmsg, $status); - } else { - error $errmsg, $status; + $log->err($errmsg); } # if return;