X-Git-Url: https://defaria.com/gitweb/?a=blobdiff_plain;f=lib%2FSpeak.pm;h=9cb944177452dbeb7714ecdfd60e83b1f7cebe30;hb=340b9e62b878286519daa08725f831868d4c00b9;hp=c18c2f7feda4c2fc8e4d60ab5286b4d0641d4ec9;hpb=cc363d84e59a0beafb118bdc7b523fce374ba2b1;p=clearscm.git

diff --git a/lib/Speak.pm b/lib/Speak.pm
index c18c2f7..9cb9441 100644
--- a/lib/Speak.pm
+++ b/lib/Speak.pm
@@ -83,7 +83,7 @@ Otherwise the text in the clipboard will be used.
 
 =item $log
 
-If provided, errors and messages will be logged to the logfile, otherwise stdout
+If provided, errors and messages will be logged to the logfile, otherwise to speak.log
 
 =back
 
@@ -103,12 +103,16 @@ Returns:
 
 =cut
 
-  if (-f "$FindBin::Bin/shh") {
-    if ($log) {
-      $log->msg("Not speaking because we were asked to be quiet - $msg");
-    } else {
-      verbose "Not speaking because we were asked to be quiet - $msg";
-    } # if
+  $log = Logger->new(
+    path        => '/var/local/log',
+    name        => 'speak',
+    timestamped => 'yes',
+    append      => 1,
+  ) unless $log;
+
+  if (-f "$FindBin::Bin/../data/shh") {
+    $msg .= ' [silent shh]';
+    $log->msg($msg);
 
     return;
   } # if
@@ -119,38 +123,18 @@ Returns:
   # Handle the case where $msg is a filehandle
   $msg = <$msg> if ref $msg eq 'GLOB';
 
-  # We can't have two speakers going at the same time so if we have an error
-  # backoff a little and try again.
-  my $attempts   = 0;
-  my $maxretries = 3;
-  my $backoff    = 2;
-
-  my ($status, @output);
-
-  while ($attempts++ < $maxretries) {
-    ($status, @output) = Execute "/usr/local/bin/gt \"$msg\"";
-
-    if ($status) {
-      my $errmsg = "Unable to speak (Status: $status) - " . join "\n", @output;
+  # Log message to log file if $log was passed in.
+  $log->msg($msg);
 
-      if ($log) {
-        $log->err($errmsg);
-      } else {
-        error $errmsg;
-      } # if
+  #$msg = quotemeta $msg;
+  $msg =~ s/\$/\\\$/g;
 
-      sleep $backoff++;
-    } else {
-      return; # We said our piece...
-    } # if
-  } # while
+  my ($status, @output) = Execute "/usr/local/bin/gt \"$msg\"";
 
-  my $errmsg = 'Maximum retries exceeded - terminating';
+  if ($status) {
+    my $errmsg = "Unable to speak (Status: $status) - " . join "\n", @output;
 
-  if ($log) {
-    $log->err($errmsg, $status);
-  } else {
-    error $errmsg, $status;
+    $log->err($errmsg);
   } # if
 
   return;